fix: Normalize timeout of 0 to be "none" instead of instant termination#77
fix: Normalize timeout of 0 to be "none" instead of instant termination#77Cruel wants to merge 1 commit intosteel-dev:mainfrom
Conversation
|
The fact that 0 is a bad default needs to be a addressed too. From my look at the api server source, it always sends back 0 for timeout. And I'm personally making some changes for this (namely adding a default timeout I can put in the config.json file). Not sure how maintainers want it set up, but it's definitely not good the way it is now. |
|
LGTM, thanks! Just noting the continue on 0 subtly falls through to the next key instead of returning immediately, but shouldn't matter in practice 👍 |
|
Yeah. The Honestly, I don't understand the purpose/origin of the different keys, so not sure if this is even necessary or desirable. 🤷♂️ |
This closes #76
Connections instantly close when using local hosted instances due to timeout being 0.
The value 0 should instead be interpreted as "no timeout" instead of "instant timeout."